Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module: tree): fix default keys bug with setTimeOut #3003

Merged
merged 1 commit into from
Mar 4, 2019
Merged

fix(module: tree): fix default keys bug with setTimeOut #3003

merged 1 commit into from
Mar 4, 2019

Conversation

simplejason
Copy link
Member

close #3001

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3001

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Mar 1, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit f302057

https://deploy-preview-3003--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 1, 2019 •
edited
Loading

Codecov Report

Merging #3003 into master will decrease coverage by 0.03%.
The diff coverage is 93.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3003      +/-   ##
==========================================
- Coverage   97.35%   97.32%   -0.04%     
==========================================
  Files         550      550              
  Lines       11454    11506      +52     
  Branches      815      816       +1     
==========================================
+ Hits        11151    11198      +47     
- Misses        190      198       +8     
+ Partials      113      110       -3
Impacted Files Coverage Δ
components/tree/nz-tree-base.service.ts 96.8% <100%> (+0.56%) ⬆️
components/tree-select/nz-tree-select.component.ts 99.47% <100%> (-0.01%) ⬇️
components/tree/nz-tree.component.ts 99.43% <100%> (+0.13%) ⬆️
components/tree/nz-tree-node.ts 88.49% <82.53%> (-3.64%) ⬇️
components/tree/nz-tree-node.component.ts 97.07% <94.44%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b3d86...f302057. Read the comment docs.

@simplejason simplejason changed the title fix(module: tree): fix default keys bug with setTimeOut [WIP] fix(module: tree): fix default keys bug with setTimeOut Mar 2, 2019
@simplejason simplejason force-pushed the fix-tree-bug branch 2 times, most recently from b0aee9b to 21bfa3c Compare March 2, 2019 16:39
@simplejason simplejason changed the title [WIP] fix(module: tree): fix default keys bug with setTimeOut fix(module: tree): fix default keys bug with setTimeOut Mar 2, 2019
hsuanxyz
hsuanxyz requested changes Mar 4, 2019
View reviewed changes
components/tree/nz-tree-node.component.ts Outdated Show resolved Hide resolved
components/tree/nz-tree-node.component.ts Outdated Show resolved Hide resolved
components/tree/nz-tree-node.ts Outdated Show resolved Hide resolved
components/tree/nz-tree.component.ts Outdated Show resolved Hide resolved
fix(module: tree): fix default keys bug with setTimeOut
f302057 
close NG-ZORRO#3001

fix(module: tree): remove unused code

fix(module: tree): fix tree spec test

fix(module: tree): fix tree demo

fix(module: tree): fix tree drag event and remove unsave code

fix(module: tree-select): remove code comments

fix(module: tree): fix demo
@hsuanxyz hsuanxyz merged commit 050faa0 into NG-ZORRO:master Mar 4, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@Ricbet
fix(module: tree): fix default keys bug with setTimeOut (NG-ZORRO#3003)
c708d6b 
close NG-ZORRO#3001

fix(module: tree): remove unused code

fix(module: tree): fix tree spec test

fix(module: tree): fix tree demo

fix(module: tree): fix tree drag event and remove unsave code

fix(module: tree-select): remove code comments

fix(module: tree): fix demo
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz
fix(module: tree): fix default keys bug with setTimeOut (NG-ZORRO#3003)
5b08e4a 
close NG-ZORRO#3001

fix(module: tree): remove unused code

fix(module: tree): fix tree spec test

fix(module: tree): fix tree demo

fix(module: tree): fix tree drag event and remove unsave code

fix(module: tree-select): remove code comments

fix(module: tree): fix demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsuanxyz hsuanxyz hsuanxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tree component nzSelectedKeys not work with setTimeout
2 participants
@simplejason @hsuanxyz